Defer to system defaults for cipher suites with urllib3 2.0+ #2922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
force-pushed
the
default_ciphers
branch
from
94d535b to
5948958
Compare
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## develop #2922 +/- ##
===========================================
- Coverage 93.43% 93.42% -0.02%
===========================================
Files 63 63
Lines 13554 13558 +4
===========================================
+ Hits 12664 12666 +2
- Misses 890 892 +2
☔ View full report in Codecov by Sentry. |
jonemo
approved these changes
Apr 27, 2023
aws-sdk-python-automation
added a commit
that referenced
this pull request
Apr 27, 2023
* release-1.29.122: Bumping version to 1.29.122 Update to latest partitions and endpoints Update to latest models Defer to system defaults for cipher suites with urllib3 2.0+ (#2922)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in urllib3 2.0, the hardcoded
DEFAULT_CIPHERSfor the ssl_context have been removed. This is a migration in a safer direction to allow user systems to define preferred cipher suites and enable modification without new releases of urllib3. This will expedite any security patching and give users finer grained control over what is chosen.Please note that botocore does not support urllib3 2.0 yet, but users are starting to see this interaction when testing for a future upgrade. To help enable that, we'll start deferring to urllib3 for this selection when an appropriate urllib3 version is installed (ref).