Honor REQUESTS_CA_BUNDLE env var in Endpoint class #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to set the path to a cert bundle. The logic is: * Any explicit value passed to get_endpoint() is used * Otherwise use REQUESTS_CA_BUNDLE if the var exists in the env * Otherwise, default to true.
|
LGTM |
|
@garnaat Also add the verify arg to the |
|
Ship it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to set the path to a cert bundle.
The logic is:
get_endpoint()is usedREQUESTS_CA_BUNDLEif the var exists in the envI'll also have to update the CLI to use this new value.
Fixes: #200