Simplify installation of test deps #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pip >=6 can handle the functionality of filtering dependencies within a single requirements files instead of needing to shim this functionality in externally.
stealthycoin
approved these changes
Dec 20, 2016
jamesls
approved these changes
Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pip >=6 can handle the functionality of filtering dependencies within a single requirements files instead of needing to shim this functionality in externally.
Since this is a development only change, it's hard to get exact numbers for what versions of pip are being used, however I suspect that developers are likely to be running the latest version. However, 83% of all downloads of boto3 via pip are using a version that supports this (compared to 81% globally).