Add pre-commit config #2988
Merged
Add pre-commit config #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
force-pushed
the
pre-commit
branch
2 times, most recently
from
e169314 to
922d425
Compare
nateprewitt
force-pushed
the
pre-commit
branch
from
922d425 to
bbfbde9
Compare
joguSD
approved these changes
Oct 7, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal variant of boto/botocore#2472 while we work out our longer term decisions on formatting. One of the suggestions from that we reviewed and seems like a solid path forward. The project is developed by one of the main pytest/tox developers and appears to have wide adoption throughout most major Python projects. We'll start this with flake8 on the main codebase (tests are omitted for the moment), and begin pulling in new features like formatting, isort, etc. as we build confidence.
Whether we wire this up to pre-commit.ci is still TBD, but this will provide a useful local option in the interim and helps us codify parts of #2959.