cc/threads: fix a few more bugs #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SoggySaussages <[email protected]>
Signed-off-by: SoggySaussages <[email protected]>
Signed-off-by: SoggySaussages <[email protected]>
Signed-off-by: SoggySaussages <[email protected]>
galen8183
reviewed
Jun 26, 2024
common/templates/context_funcs.go
Outdated
| if duration < 60 || duration > 10080 { | ||
| return nil, errors.New("createThread 'auto_archive_duration' must be and integer between 60 and 10080") | ||
| start.AutoArchiveDuration = tmplToInt(opt) | ||
| if start.AutoArchiveDuration < 60 || start.AutoArchiveDuration > 10080 { |
There was a problem hiding this comment.
Shouldn't this check exactly 60, 1440, 4320, and 10080, as stated in the thread metadata docs?
Currently giving any other value won't create the thread, with integers between 60 and 10080 failing silently.
There was a problem hiding this comment.
Done this in 191fa78, I've also added a designated type and constants for auto archive duration for readability in 283301f.
Previously users could provide any integer between 60 and 10080 as a duration. This caused createThread or editThread to fail given that Discord only permits 60, 1440, 4320, *or* 10080. Now any non permissible value errors. Signed-off-by: SoggySaussages <[email protected]>
Signed-off-by: SoggySaussages <[email protected]>
ashishjh-bst
pushed a commit
to ashishjh-bst/yagpdb
that referenced
this pull request
Jun 27, 2024
* cc/threads: fix createThread archive duration Signed-off-by: SoggySaussages <[email protected]> * cc/threads: allow creation of news threads Signed-off-by: SoggySaussages <[email protected]> * discrdgo: ChannelType.IsThread ret true for news Signed-off-by: SoggySaussages <[email protected]> * cc/threads: error typo Signed-off-by: SoggySaussages <[email protected]> * cc/threads: restrict auto archive dur Previously users could provide any integer between 60 and 10080 as a duration. This caused createThread or editThread to fail given that Discord only permits 60, 1440, 4320, *or* 10080. Now any non permissible value errors. Signed-off-by: SoggySaussages <[email protected]> * discordgo: add type for auto archive Signed-off-by: SoggySaussages <[email protected]> --------- Signed-off-by: SoggySaussages <[email protected]>
ashishjh-bst
pushed a commit
to ashishjh-bst/yagpdb
that referenced
this pull request
Jun 27, 2024
* cc/threads: fix createThread archive duration Signed-off-by: SoggySaussages <[email protected]> * cc/threads: allow creation of news threads Signed-off-by: SoggySaussages <[email protected]> * discrdgo: ChannelType.IsThread ret true for news Signed-off-by: SoggySaussages <[email protected]> * cc/threads: error typo Signed-off-by: SoggySaussages <[email protected]> * cc/threads: restrict auto archive dur Previously users could provide any integer between 60 and 10080 as a duration. This caused createThread or editThread to fail given that Discord only permits 60, 1440, 4320, *or* 10080. Now any non permissible value errors. Signed-off-by: SoggySaussages <[email protected]> * discordgo: add type for auto archive Signed-off-by: SoggySaussages <[email protected]> --------- Signed-off-by: SoggySaussages <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following bugs:
Signed-off-by: SoggySaussages [email protected]