customcommands: relax restriction on execCC from command templates #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishjh-bst
pushed a commit
to ashishjh-bst/yagpdb
that referenced
this pull request
Jun 27, 2024
ashishjh-bst
pushed a commit
to ashishjh-bst/yagpdb
that referenced
this pull request
Jun 27, 2024
ashishjh-bst
added a commit
to ashishjh-bst/yagpdb
that referenced
this pull request
Jun 28, 2024
…lates (botlabs-gg#1684)" This reverts commit cd13c54.
SoggySaussages
added a commit
to SoggySaussages/yagpdb-main
that referenced
this pull request
Jul 10, 2024
…plates (botlabs-gg#1684)" This reverts commit 3f743b0.
ashishjh-bst
pushed a commit
that referenced
this pull request
Aug 28, 2024
galen8183
pushed a commit
to galen8183/yagpdb
that referenced
this pull request
Nov 12, 2024
* Reapply "templates: block nested template executors (botlabs-gg#1677)" This reverts commit 8b8ebbc. * Reapply "customcommands: relax restriction on execCC from command templates (botlabs-gg#1684)" This reverts commit 3f743b0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes a restriction on
execCCcalls from command templates (e.g., moderation DM templates) introduced in #1677. Specifically, we now permit oneexecCCcall from command templates as long as it is not nested. This new restriction still resolves the original issue that #1677 set out to address but is less prone to cause breakage in userland.