reminders: verify that member can run remindme in target channel
#1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jo3-l
force-pushed
the
fix/reminder-target-channel-check-cmd-overrides
branch
from
caa9d95 to
733728f
Compare
…d.GetSettings Previously this logic was done by the caller, but it should be the responsibility of the GetSettings procedure. This commit also incidentally fixes a minor bug in CommonContainerNotFoundHandler, which previously did not consider command overrides properly if used in a thread.
jo3-l
force-pushed
the
fix/reminder-target-channel-check-cmd-overrides
branch
from
733728f to
8b4c9c9
Compare
ashishjh-bst
pushed a commit
to ashishjh-bst/yagpdb
that referenced
this pull request
Jun 27, 2024
…otlabs-gg#1674) * commands: move code handling cmd overrides for threads into YagCommand.GetSettings Previously this logic was done by the caller, but it should be the responsibility of the GetSettings procedure. This commit also incidentally fixes a minor bug in CommonContainerNotFoundHandler, which previously did not consider command overrides properly if used in a thread. * reminders: verify that member can run `remindme` in target channel
ashishjh-bst
pushed a commit
to ashishjh-bst/yagpdb
that referenced
this pull request
Jun 27, 2024
…otlabs-gg#1674) * commands: move code handling cmd overrides for threads into YagCommand.GetSettings Previously this logic was done by the caller, but it should be the responsibility of the GetSettings procedure. This commit also incidentally fixes a minor bug in CommonContainerNotFoundHandler, which previously did not consider command overrides properly if used in a thread. * reminders: verify that member can run `remindme` in target channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a member used
remindme ... -channel #fooandremindmewas disabled via command/channel overrides in channel#foo, the command would still go through as long as the member had send message permissions in#foo. This PR fixesremindmeto check command overrides as well.