commands/tmplexec: also return *discordgo.MessageSend
#1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also return `*discordgo.MessageSend` after executing a command via a fake message. Commit 97b021d ("customcommands: link to ccs in cc command ") via PR botlabs-gg#1624 introduced a side effect where constructs such as `{{ exec "cc" "1" }}` no longer worked, thus resulting in breakage. This patch does *not* fully restore the former state, however seeing as the aforementioned commit broke things in a very subtle way it seems acceptable to introduce a new, different behaviour. Admittedly, with the current state of in-built commands responding with all sorts of things that may or may not be writable to a CC variable, this only confuses things further, but at least it is working again(TM). At some point in the future we could consider sorting these "inconsistencies" out and making it "just werk" with custom commands. In light of the currently ongoing migration from GORM to sqlboiler, this undertaking does not seem too far-fetched. Signed-off-by: Luca Zeuch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also return
*discordgo.MessageSendafter executing a command via afake message.
Commit 97b021d ("customcommands: link to ccs in cc command ") via
PR #1624 introduced a side effect where constructs such as
{{ exec "cc" "1" }}no longer worked, thus resulting in breakage.This patch does not fully restore the former state, however seeing as
the aforementioned commit broke things in a very subtle way it seems
acceptable to introduce a new, different behaviour.
Admittedly, with the current state of in-built commands responding with
all sorts of things that may or may not be writable to a CC variable,
this only confuses things further, but at least it is working again(TM).
At some point in the future we could consider sorting these
"inconsistencies" out and making it "just werk" with custom commands. In
light of the currently ongoing migration from GORM to sqlboiler, this
undertaking does not seem too far-fetched.
Signed-off-by: Luca Zeuch [email protected]