Youtube Publishing reliability improvements. #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves from a channel and last published video based cache to a video list cache.
The issue with the original implementation is that you can upload videos before another video, but publish it at a later time, causing the first video to be not notified by the bot. Instead of keeping last video ID per channel, this effectively moves to a video based cache.
It caches all video ids the bot has published in last x days, where x is default 1 day, but configurable from environment, and on receiving an event for a video, it checks if the video in the event published was published more than x days ago, or is in the video cache, the bot will publish the video if it isn't in the cache.
A possible downside is that certain channels upload videos quite in advance, and premiere it at a later date, if this difference is more than the video list cache days, the video will not be published.