Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: thanks detection logic for blacklist/whitelist #1613

Conversation

zeing
Copy link
Contributor

@zeing zeing commented Feb 7, 2024

Problem

When you add channels for
Whitelisted channels for giving rep using thanks
or
Blacklisted channels for giving rep using thanks
in reputation in /manage/server_id/reputation page

Bot still allows in threads in blacklisted channels
Bot doesn't work in threads in whitelisted channels

de parent channel check
@zeing zeing changed the title fix: thanks detection logic blacklist/whitelist fix: thanks detection logic for blacklist/whitelist Feb 7, 2024
@zeing zeing requested a review from SoggySaussages February 8, 2024 03:13
Copy link
Contributor

@ashishjh-bst ashishjh-bst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor to make the code readable.

@zeing zeing requested a review from ashishjh-bst February 13, 2024 07:28
@ashishjh-bst ashishjh-bst merged commit 4f5853c into botlabs-gg:dev Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants