feat(youtube): Refactor YouTube matching logic #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit redesigns `Plugin.parseYtUrl`, making use of the `net/url.Url` struct to extract out key elements of YouTube URLs, minimising the utilisation of RegEx in the method, alongside simplifying remaining expressions. Additionally, this adds the `Plugin.parseYtVideoID` method, to extract some of the parsing logic out of `Plugin.parseYtUrl`, and introduces support for URLs to YouTube shorts.
Updates the signature of `Plugin.getYtChannel`, to work the the redesigned `Plugin.parseYtUrl` method.
Updates the `Plugin.HandleNew` to use `net/url.Url`, inline with the new signature of `Plugin.getYtChannel`. This includes updating some variable names, to avoid blocking the use of the `net/url` package.
ashishjh-bst
changed the title
|
I should note: I think the domain checking logic being handled by If anyone has a suggestion in how to rewrite the error reporting, I'd like to add that as another change... |
Updates `Plugin.parseYtUrl`, using `fmt.Errorf` to include the URL element, which resulted in it failing to be parsed.
ashishjh-bst
added a commit
to ashishjh-bst/yagpdb
that referenced
this pull request
Mar 15, 2023
ashishjh-bst
added a commit
that referenced
this pull request
Mar 15, 2023
Co-authored-by: Ashish Jhanwar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aimed at updating elements of the URL parsing logic for the YouTube feed, by adding checks of the URL path in order to streamline parsing logic, as well as raise more relevant, context-sensitive errors.
Additionally, these changes come alongside using these changes to add support for URLs using the
shortspath in the process.