This repository has been archived by the owner on Mar 5, 2023. It is now read-only.
forked from bwmarrin/discordgo
-
Notifications
You must be signed in to change notification settings - Fork 9
change int64 -> null.Int64 #10
Open
Satty9361
wants to merge
239
commits into
botlabs-gg:yagpdb
Choose a base branch
from
Satty9361:patch-8
base: yagpdb
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getter Function for marshalnil field
New endpoint to delete all reactions of particular emoji
…or full customization
Does the "string" tag work with null.Int64? |
That's correct. null.Int64 indeed does not work with string tag. I had two solutions in mind. One was to use null.String similar to #9 however I thought it might be better to define a custom datatype and use it in all places where nullable IDs are allowed for ease of use. Let me know what you think and in that case probably the field in #9 can also be updated to use |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #9 changing to null.Int64 allows to disconnect users from voice channels in this case.