Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/handle schedule activity not exist #17

Merged
merged 8 commits into from
Aug 6, 2014

Conversation

ggreg
Copy link
Contributor

@ggreg ggreg commented Aug 5, 2014

The purpose of these changes is:

  • To schedule an activity without getting its type from SWF with an API call. Formerly it used the .get_or_create() method of a QuerySet to get the type and create it if necessary. It involved one API call for each task to schedule.
  • To launch the tests without AWS credentials and consequently fix the Travis build!

@darkjh
Copy link

darkjh commented Aug 6, 2014

👍

@ggreg ggreg mentioned this pull request Aug 6, 2014
ggreg added a commit that referenced this pull request Aug 6, 2014
…ty-not-exist

Update/handle schedule activity not exist
@ggreg ggreg merged commit 373701e into master Aug 6, 2014
@ggreg ggreg deleted the update/handle-schedule-activity-not-exist branch August 6, 2014 16:38
self.domain.name))
try:
activity_type.save()
except swf.exceptions.AlreadyExistsError:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggreg swf is not imported, right? Only swf.model is imported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants