Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeoutError has not attritube 'reason' #13

Closed
ggreg opened this issue Aug 4, 2014 · 0 comments · Fixed by #14
Closed

TimeoutError has not attritube 'reason' #13

ggreg opened this issue Aug 4, 2014 · 0 comments · Fixed by #14
Assignees
@ggreg
Labels
bug

Comments

@ggreg
Copy link
Contributor

ggreg commented Aug 4, 2014

swf.executor maps a timeout event to a TimeoutError object that does not have a reason attribute. If the task has the flag raises_on_failure enabled, swf.Executor.resume() will wrap the TimeoutError in a TaskException. It then raises in swf.Executor.replay() that logs a message. It fails to make the message from the reason attribute.
@ggreg ggreg added the bug label Aug 4, 2014
@ggreg ggreg self-assigned this Aug 4, 2014
ggreg pushed a commit that referenced this issue Aug 4, 2014
Update exceptions #13: add attribute task to TaskException
adb63b1
ggreg pushed a commit that referenced this issue Aug 4, 2014
Update swf.executor #13: use TaskException.task.name instead of reaso…
9c16046 
…n attribute
@ggreg ggreg mentioned this issue Aug 4, 2014
Merged
@ggreg ggreg closed this as completed in #14 Aug 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggreg ggreg

Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/task timeout botify-labs/simpleflow
1 participant
@ggreg