Fix HTTPStatusException propagation #1109
Conversation
AndrejMitrovic
added
the
type-bug
|
Well I really thought this would fix it, but apparently there are more hidden bugs. Sigh. |
|
Ah maybe it also requires Jay's PR. |
The reason I say this is because there are still no logs like this: https://github.com/bpfkorea/agora/blob/b602254d522f5bc2e5b5e96525c4d61e7c9180ff/source/agora/network/NetworkManager.d#L186 |
AndrejMitrovic
force-pushed
the
fix-circle
branch
from
ed8b9a0
to
4e68654
Compare
We need to handle vibe.d exceptions properly, if an HTTPStatusException is thrown we need to propagate it to the calling code so it can be properly handled.
AndrejMitrovic
force-pushed
the
fix-circle
branch
from
4e68654
to
2c1791e
Compare
Nope it didn't work with the combination of that. So my PR fixes one bug but it doesn't solve the underlying problem. |
AndrejMitrovic
changed the title
It might resolve the CircleCI failures, but it would only treat the symptom and not solve the underlying problem.
Codecov Report
@@ Coverage Diff @@
## v0.x.x #1109 +/- ##
==========================================
+ Coverage 78.58% 78.62% +0.03%
==========================================
Files 83 84 +1
Lines 7912 7953 +41
==========================================
+ Hits 6218 6253 +35
- Misses 1694 1700 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
With the second commit the log files finally show connecting to the FullNode:
But this is just treating the symptom and not fixing the underlying problem. However maybe we can at least be unblocked.. |
No description provided.