-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: own function access keys without write permission #11
Conversation
fails on different keys with same value, which indicates a bug?
@race-of-sloths Please include this PR |
@petersalomonsen Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
The average score is 8 @petersalomonsen check out your results on the Race of Sloths Leaderboard! and in the profile What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petersalomonsen Thank you for authoring the fix and introducing the tests!
@race-of-sloths score 8
🌟 Score recorded!@frol, thank you for scoring this pull request in the Race of Sloths! |
all not needed when there is only one condition
@frol "code-style" and "unit-test" CI workflows are now updated to use Al CI workflows pass in the PR to my own fork |
## 🤖 New release * `near-socialdb-client`: 0.3.1 -> 0.3.2 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.3.2](v0.3.1...v0.3.2) - 2024-07-30 ### Fixed - Allow function access keys to be used without explicit write permission (this reflects the SocialDB contract implementation) ([#11](#11)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
✅ PR is finalized!Your contribution is much appreciated with a final score of 8! Congratulations @petersalomonsen! Your PR was highly scored and you completed another monthly streak! To keep your monthly streak make another pull request next month and get 8+ score for it |
As can be seen if running the tests without the fix, we get the error message
ERROR: Social DB requires more storage deposit, but we cannot cover it when signing transaction with a Function Call only access key
if using a function access key that does not have explicit write permission, but comes from the account that we want to write to. This should not fail, and this PR reproduces and fixes the issue.Here is the output of running the unit tests without the fix:
In addition this PR adds github codespaces setup, and a workflow for running the unit tests. The "code-style" CI workflow is also updated to use
ubuntu-latest
andrust-cache
because it failed with the current setup.fixes NEAR-DevHub/neardevhub-bos#897