Allow parent project to override options #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Turner <[email protected]>
|
Please provide a description. What prompted this and how did you solve it? |
Done |
varunagrawal
reviewed
Nov 1, 2024
| @@ -1,5 +1,11 @@ | |||
| cmake_minimum_required(VERSION 3.0) | |||
|
|
|||
| # allow parent project to override options | |||
There was a problem hiding this comment.
Nitpick: Would your project be the parent project or the dependent project? Other than potentially updating this, your PR comment explains the need well. :)
There was a problem hiding this comment.
It would be the dependent project but in this case is acting as the parent as it has to build gtsam (eg by fetchcontent)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to depend on gtsam without boost, but when using fetch content I couldn't override the options relating to boost usage to disable it
I fixed this by setting polity CMP0077