Improve the DiscreteFactorFromErrors
#1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellaert
approved these changes
Oct 10, 2024
| * the leaves of the input DecisionTree. | ||
| */ | ||
| template <typename X, typename Func> | ||
| AlgebraicDecisionTree(const DecisionTree<L, X>& other, Func f) |
There was a problem hiding this comment.
An ADT stores doubles, so ideally Func should be enforced to return a double. We can merge as is but any signature that does not will yield strange compilation errors.
There was a problem hiding this comment.
Hmm I am not sure I know how to enforce that. :( I'll check later.
|
Please merge after merging no_hiding so this targets develop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new constructor to
AlgebraicDecisionTreeso we can reduce some boilerplate code.Improved the docstring for
DiscreteFactorFromErrors.