Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Martin Brossard's Implementation of SE_2(3) #1582

Closed
wants to merge 1 commit into from
Closed

Conversation

ProfFan
Copy link
Collaborator

@ProfFan ProfFan commented Jul 19, 2023

Expect more in this series. Basically what I did is copying from Martin's GTSAM fork https://github.com/mbrossar/gtsam , fixing merge conflicts, and style fixes.

@dellaert
Copy link
Member

Hi @ProfFan @mbrossar ,
could you perhaps elaborate in the PR comment on how this differs from NavState? It seems very similar.
If it is only the absence of "Lie-group" traits, maybe these could simply be added by adding (in a separate file) the traits to "complete" NavState into a Lie group.
Frank

@varunagrawal
Copy link
Collaborator

I agree with Frank. Mathematically, NavState is equivalent to $SE_2(3)$ but needs all the Lie traits implemented, something which has been on my TODO list for a while now.

@ProfFan
Copy link
Collaborator Author

ProfFan commented Jul 20, 2023

Yup, I am just testing waters :) Let's find a slot to get that done.

@ProfFan ProfFan closed this Jul 20, 2023
@varunagrawal varunagrawal deleted the fan/add_se23 branch October 22, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants