Eigen, cuSparse and SuiteSparse solvers #1396
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in testNonlinearOptimizer
due to references to LinearSolverParams, we have to be careful copying+moving
Note that Solver doesn't need these functions - only Params needs to know.
* SuiteSparse & cuSPARSE can only do Cholesky - remove QR option * Iterative Solvers: construct from LinearSolverParams and check for null parameters in constructor * make_shared<> in LinearSolver::CreateFromParameters
sparseJacobian is now templated on its return type for more flexibility
SuiteSparse/cuSPARSE need "int" type ordering
|
Could you please edit PR comment to say what this is about, with some context? |
|
Also, CI fails :-) |
ProfFan
changed the title
|
Can you merge in develop and resolve conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing #111 for clean diff
This PR adds a common interface for other kinds of linear solvers. Not perfect but is indeed useful.
tested with yetong and it seems to be accelerating stuff for a bit