Add tensorflow/swift-apis as a SwiftPM dependency. #260
Conversation
This enables building SwiftFusion using stock toolchains from swift.org/download.
|
Thank you very much Dan! I just tried compiling this with latest Swift nightly, and this (https://gist.github.com/ProfFan/638f61aff223bfcbea94b2ddb026497a) is what I've got. There is one compiler crash, and a lot of errors related to |
|
I have got past the |
|
Actually it's more than this, it appears that somehow |
|
Ok I see the problem. X10 needs to be built separately, but is it able to build x10 with an existing tensorflow install? or is it required to use the TF source? Will these two coexist? @BradLarson Could you help me debug this? Thanks a lot! |
|
Hi Fan, Did you follow "build instructions" above and install pre-built X10 libraries? I believe they're currently available only for macOS and Windows – not Linux unfortunately. The instructions for "building libraries depending on Let me know if you need any help! I'm happy to video call if you'd like. |
|
Hi Dan, Thanks for the instructions! I have checked the building instructions and wonder if x10 can be built with a system-packaged tensorflow with headers? I think this is a very important question, as if x10 can be built separately then there will be a much higher chance that it will survive TF updates. |
Sure thing! I believe @compnerd can provide a more accurate answer to your question about system-packed TensorFlow and X10. I recall discussing such things before - using a system package manager seems more heavyweight and platform-specific, but maybe it's more robust against breakages as you suggest. |
|
@ProfFan - When building a Swift for TensorFlow toolchain from scratch, X10 and TensorFlow are built from a specified TensorFlow version, and you have to manually move that version up to build against a new version of TensorFlow. In the worst case, you can still build these libraries as part of building a stock toolchain + swift-apis from scratch. I don't know if these steps are documented anywhere, so I'll write down the sequence of commands needed to create a new toolchain based on the stock Swift compiler from scratch: export TF_NEED_CUDA=1
mkdir swift-source
cd swift-source
git clone https://github.com/apple/swift.git
./swift/utils/update-checkout --clone --skip-repo swift
./swift/utils/build-toolchain buildbot_linux
git clone https://github.com/tensorflow/swift-apis.git
cmake -B BinaryCache -D BUILD_SHARED_LIBS=YES -D CMAKE_BUILD_TYPE=Release -D CMAKE_INSTALL_PREFIX=/media/nvidia/Data/Development/swift-source/swift-nightly-install/usr -D CMAKE_Swift_COMPILER=/media/nvidia/Data/Development/swift-source/swift-nightly-install/usr/bin/swiftc -D TENSORFLOW_USE_STANDARD_TOOLCHAIN=YES -G Ninja -S ./swift-apis
cmake --build BinaryCache --target install
tar -czf swift-tensorflow-stock-Jetson.tar.gz -C swift-nightly-install/ usr(you may need to alter a few of the hardcoded paths above, this was a quick copy-paste) For a Jetson build, you also need to add the following at the beginning to specify CUDA architectures: export TF_CUDA_COMPUTE_CAPABILITIES=compute_53,compute_62,compute_72In the process of building this, all headers and binaries are generated for X10 and TensorFlow. I can extract and package these for Ubuntu, based on our 0.13 toolchains. That should contain everything you'd need to build swift-apis as a package, and would serve as long as you didn't need to advance beyond TensorFlow 2.4.0. Would that be useful to have? If so, which Ubuntu configurations would be most useful to focus on? |
|
OK, I tried it out and I think my idea of extracting the binary libraries from the completed toolchains will work. This is a version of the X10 standalone libraries (with TensorFlow headers) that builds on Ubuntu 18.04, CPU-only, with Dan's setup here. You might need to find the right Swift toolchain to use, however, because the If you want me to, I can create X10 snapshots from all of our Ubuntu variants and add them to the Windows and macOS snapshots linked on our development page. |
|
@BradLarson Thanks a lot Brad! One last question - is it possible to build X10 with only the TF headers in a vendor install of TF? For example Arch Linux ships TF with full headers as a prebuilt package. In my experiments the X10 cmake seems to be always cloning from GitHub the full source tree. |
|
But you are right, since Swift lives in a prefix we can definitely ship the TF libraries with the toolchain (separate from system TF) as well. |
|
@ProfFan - I don't believe that libx10 can be built without access to the TensorFlow source, due to its need to compile in elements of XLA. Not entirely sure if the same is true for our eager-mode access, but I believe we build that in, too. Our toolchains exist independently of the system-installed TensorFlow, as does a binary library package like the one I linked above, and don't make use of it if it is available. Our TensorFlow support is pretty much standalone. |
|
@BradLarson Thanks for the explanation! That is totally good :) |
|
I've created both CUDA 11 and CPU-only Ubuntu 18.04 X10 packages and linked them here: tensorflow/swift-apis#1182 . I figured those would be the two most popular platforms for people carrying this on in the near term, but can add others if needed. |
Motivation
This enables building SwiftFusion using stock toolchains from swift.org/download.
swift buildwill clone and buildtensorflow/swift-apisas a regular SwiftPM dependency. Eventually, we would like to stop releasing custom toolchains bundled with pre-installedtensorflow/swift-apis.Build instructions
It is possible to build
tensorflow/swift-apisand dependencies like SwiftFusion using stock toolchains by installing pre-built X10 libraries (currently available only for macOS and Windows).After installing (e.g. to
$HOME/Libraryon macOS), build with SwiftPM via the following:$ swift build -Xcc -I$HOME/Library/tensorflow-2.4.0/usr/include -Xlinker -L$HOME/Library/tensorflow-2.4.0/usr/lib -Xswiftc -DTENSORFLOW_USE_STANDARD_TOOLCHAINswift testis known not to work on macOS fortensorflow/swift-apisand dependencies due to SR-14008:Library not loaded: /usr/lib/swift/libswift_Differentiation.dylib.Testing
Before merging, let's verify that
swift build,swift run, andswift testworks for swift.org/download toolchains across platforms, and update GitHub Actions CI so that it passes:swift runandswift testcurrently both fail due to SR-14008: