safe_unlink (was: truncate_and_unlink) #6301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the previous implementation caused collateral damage on hardlink-copies of a repository, see: borgbackup#6286
|
@enkore @textshell can you please review? |
enkore
approved these changes
Feb 15, 2022
|
Line 208 in 4a2ab49 maybe easier to see there than in the diff. |
ThomasWaldmann
changed the title
it usually does not truncate any more, only under "disk full" circumstances and only if there is only one hardlink.
ThomasWaldmann
force-pushed
the
safe-unlink-master
branch
from
3f3e5f5
to
b292e15
Compare
This was referenced Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous implementation caused collateral damage on hardlink-copies of a repository,
see: #6286