-
-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve clarify borg check --verify-data (#5808) #5860
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5860 +/- ##
==========================================
- Coverage 83.84% 83.50% -0.35%
==========================================
Files 37 38 +1
Lines 9763 10353 +590
Branches 1621 1710 +89
==========================================
+ Hits 8186 8645 +459
- Misses 1104 1205 +101
- Partials 473 503 +30
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe re-read the ticket.
the repository part of the check is a very simple and low-level check. no crypto there, just some crc32 checking etc.
the crypto stuff that also needs the key is in the archives part of the check. also --verify-data happens in the archives part of the check.
if none of the --repository-only or --archives-only options are given. borg does both checks, first the lowlevel repo check, then the higher level archives check.
docs/usage/check.rst.inc
Outdated
- The repository check can be skipped using the ``--archives-only`` option or the | ||
``--verify-data`` option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not correct.
docs/usage/check.rst.inc
Outdated
slow. This option also implies ``--archives-only``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not correct.
src/borg/archiver.py
Outdated
- The repository check can be skipped using the ``--archives-only`` option. | ||
- The repository check can be skipped using the ``--archives-only`` option or the | ||
``--verify-data`` option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not correct.
src/borg/archiver.py
Outdated
slow. | ||
slow. This option also implies ``--archives-only``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not correct.
Is this any better? |
- In verify-data mode, a complete cryptographic verification of the archive data | ||
integrity is performed. This conflicts with ``--repository-only`` as this mode | ||
only makes sense if the archive checks are enabled. The full details of this mode | ||
are documented below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw you do not need to update these files, that is done automatically at release time (auto-generated from archiver.py).
- In verify-data mode, a complete cryptographic verification of the archive data | ||
integrity is performed. This conflicts with ``--repository-only`` as this mode | ||
only makes sense if the archive checks are enabled. The full details of this mode | ||
are documented below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, much better!
thanks! |
This should close #5808 and count towards completion of #5129.