Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add notice about defective hardware to check documentation (#5753) #5859

Merged
merged 2 commits into from Jun 19, 2021
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jun 18, 2021

This is the back-port of #5855 for #5129.

@ThomasWaldmann
Copy link
Member

this needs to be done in archiver.py.

@ghost
Copy link
Author

ghost commented Jun 19, 2021

This should cover that. It now includes both documentation patches.

@ThomasWaldmann
Copy link
Member

something got mixed up now...

@ghost
Copy link
Author

ghost commented Jun 19, 2021

Ugh. I'll try to fix it.

@ghost
Copy link
Author

ghost commented Jun 19, 2021

That should do it.

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2021

Codecov Report

Merging #5859 (869aeb3) into 1.1-maint (bc36ccb) will decrease coverage by 0.57%.
The diff coverage is n/a.

❗ Current head 869aeb3 differs from pull request most recent head 3e43b19. Consider uploading reports for the commit 3e43b19 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           1.1-maint    #5859      +/-   ##
=============================================
- Coverage      79.90%   79.33%   -0.58%     
=============================================
  Files             27       27              
  Lines          10456    10456              
  Branches        1841     1841              
=============================================
- Hits            8355     8295      -60     
- Misses          1578     1634      +56     
- Partials         523      527       +4     
Impacted Files Coverage Δ
src/borg/archiver.py 81.38% <ø> (+0.28%) ⬆️
src/borg/xattr.py 59.61% <0.00%> (-19.72%) ⬇️
src/borg/platform/__init__.py 75.00% <0.00%> (-15.00%) ⬇️
src/borg/platform/base.py 79.62% <0.00%> (-3.71%) ⬇️
src/borg/archive.py 81.61% <0.00%> (-0.75%) ⬇️
src/borg/helpers.py 87.48% <0.00%> (-0.36%) ⬇️
src/borg/repository.py 85.13% <0.00%> (-0.20%) ⬇️
src/borg/cache.py 85.33% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc36ccb...3e43b19. Read the comment docs.

@ThomasWaldmann ThomasWaldmann merged commit 9d59255 into borgbackup:1.1-maint Jun 19, 2021
@ghost ghost deleted the check_notice branch June 19, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants