[DOC] #4118 - Explain difference between --exclude and --pattern. #4783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4783 +/- ##
==========================================
+ Coverage 83.84% 83.91% +0.07%
==========================================
Files 37 37
Lines 9762 9762
Branches 1622 1622
==========================================
+ Hits 8185 8192 +7
+ Misses 1103 1097 -6
+ Partials 474 473 -1
Continue to review full report at Codecov.
|
src/borg/archiver.py
Outdated
|
|
||
| Via ``--pattern`` or ``--patterns-from`` you can define BOTH inclusion and exclusion | ||
| of files using pattern prefixes ``+`` and ``-``. With ``--exclude`` and | ||
| ``--exlude-file`` ONLY excludes are defined. |
There was a problem hiding this comment.
it is not --exlude-file, but --exclude-from.
one could also continue the last sentence with "... and you need to use --include ... to define includes ONLY.
There was a problem hiding this comment.
Stupid me...
But I'm not sure what you mean with --include. There is no --include mentioned in e.g. borg create, is this a new undocumented option?
fantasya-pbem
commented
Oct 17, 2019
…ttern Note shortened.
|
Do we need same change for 1.1-maint?h |
elho
pushed a commit
to elho/borg
that referenced
this pull request
Mar 17, 2020
…ttern. (borgbackup#4783) docs: Explain difference between --exclude and --pattern, fixes borgbackup#4118
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my opinion the borg help pattern is already quite good in explaining the --exclude and --pattern features, so I just added a note that explicitly states the additional prefix in --pattern lines.
If you read this help carefully it should be sufficient.