crypto: fixes & remove AES-GCM #2888
Conversation
(-Wstrict-prototypes, Cyton forgets a "void")
| @@ -67,7 +67,6 @@ cdef extern from "openssl/evp.h": | |||
| pass | |||
|
|
|||
| const EVP_CIPHER *EVP_aes_256_ctr() | |||
| const EVP_CIPHER *EVP_aes_256_gcm() | |||
There was a problem hiding this comment.
i intentionally did not remove gcm although some people have bad feelings about it. other people have also bad feelings about patents (even with the patent license for FOSS and openssl), so there would be gcm as option for them.
technically, I'ld also choose ocb over gcm.
There was a problem hiding this comment.
chapoly > either, like I argued previously. With no performance impact.
There was a problem hiding this comment.
So, remove OCB as well.?
There was a problem hiding this comment.
no, keep it, it is hw accelerated and fastest.
| @staticmethod | ||
| def requirements_check(): | ||
| @classmethod | ||
| def requirements_check(cls): |
There was a problem hiding this comment.
interesting, i didn't notice malfunction here. did you file a bug at cython?
There was a problem hiding this comment.
It's not a malfunction, just slightly incorrect code.
foo something(); // this is not a prototype for the function below, compiler can't typecheck!
foo
something() { // this function was not declared above!
return ...;
}
Codecov Report
@@ Coverage Diff @@
## master #2888 +/- ##
==========================================
+ Coverage 86.21% 86.23% +0.02%
==========================================
Files 23 23
Lines 8813 8813
Branches 1484 1484
==========================================
+ Hits 7598 7600 +2
+ Misses 823 822 -1
+ Partials 392 391 -1
Continue to review full report at Codecov.
|
Fixups for #1034