Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data/prino #87

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Data/prino #87

wants to merge 4 commits into from

Conversation

tillwenke
Copy link
Collaborator

@tillwenke tillwenke commented Sep 28, 2024

@tillwenke
Copy link
Collaborator Author

tillwenke commented Sep 28, 2024

Uploading image.png…
rating for unrated spots

@tillwenke
Copy link
Collaborator Author

tillwenke commented Sep 28, 2024

this is mostly to verify that the integration of the data went well.
by show.py, server.py.
close this pr after data has been integrated

@tillwenke tillwenke linked an issue Sep 28, 2024 that may be closed by this pull request
@tillwenke
Copy link
Collaborator Author

add "invited" to signals

@tillwenke
Copy link
Collaborator Author

add columns data are not yet part of the points df to it.
it contains some features that we wanted to integrate in the future and others that I did not want to get lost (about the driver).

@bopjesvla
Copy link
Owner

add "invited" to signals

that doesn't quite fit, right? being invited is not a signal, and we can't add it to the user-facing dropdown as a signal. the question is: why did the driver think prino was a hitchhiker? the answer is prolly context clues, and in that case im okay with a null value

@tillwenke
Copy link
Collaborator Author

TODO: compare against his spots that are already on the map - Prino (Hitchwiki)

@bopjesvla
Copy link
Owner

bopjesvla commented Oct 12, 2024

let's set the datetime to the current moment, the ride's datetime will make sure it shows correctly

@tillwenke tillwenke removed the request for review from bopjesvla October 25, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge the laurens prins database
2 participants