Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some support for the Lua API #319

Merged
merged 14 commits into from
May 7, 2024
Merged

Conversation

paulyoung
Copy link
Contributor

I've been using these changes locally and they appear to work as expected for my project.

I would like to add an example but will need to follow up on that. It would require its own Cargo.toml (to add a main.pdz file) and I'm not sure if that will "just work".

@github-actions github-actions bot added docs Improvements or additions to documentation api About Playdate API, bindings and all over that. labels Apr 21, 2024
@paulyoung
Copy link
Contributor Author

Relates to #41

@boozook
Copy link
Owner

boozook commented Apr 22, 2024

Thanks for the work you've done, it's very cool and that was a very lack of this! ❤️‍🔥

I would like to add an example but will need to follow up on that. It would require its own Cargo.toml (to add a main.pdz file) and I'm not sure if that will "just work".

We have [package.metadata.playdate.dev-assets] metadata. Especially for tests and examples.
It works similarly to the cargo's [dev-dependencies]:

  • inherits by main assets ([package.metadata.playdate.assets])
  • so in the example packages includes both - assets and dev-assets
  • dev-assets are not included in the non-dev builds (packages produced for example cargo target)

There is example and example that uses that assets, and there's doc. So, it should just works.

Copy link
Owner

@boozook boozook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your branch - it could be rebase or just merge main into your branch - 👌🏻. That's need because I've made a follow-up to your prev PR with versions increment (#320).

Also there are some little changes I suggesting:

api/lua/Cargo.toml Outdated Show resolved Hide resolved
api/playdate/Cargo.toml Show resolved Hide resolved
api/lua/README.md Outdated Show resolved Hide resolved
@boozook boozook added this to the Full API Coverage milestone Apr 22, 2024
@boozook boozook linked an issue Apr 22, 2024 that may be closed by this pull request
@paulyoung
Copy link
Contributor Author

I have an example put together but something is going wrong with the asset. It works in a separate project but not in my example. I'm going to investigate further.

api/lua/Cargo.toml Outdated Show resolved Hide resolved
api/lua/Cargo.toml Outdated Show resolved Hide resolved
api/lua/Cargo.toml Outdated Show resolved Hide resolved
api/lua/README.md Outdated Show resolved Hide resolved
api/lua/examples/README.md Outdated Show resolved Hide resolved
@paulyoung
Copy link
Contributor Author

For what it’s worth, I’m not relying on using the Lua API for my own use case anymore but this was already done so I wanted to try and finish it up.

api/lua/Cargo.toml Outdated Show resolved Hide resolved
@boozook
Copy link
Owner

boozook commented May 6, 2024

Just notice, looking to commit afd669b
I have an issue for nix - #94.

May be in future if you want, could be awesome.

@paulyoung paulyoung requested a review from boozook May 6, 2024 06:43
Copy link
Owner

@boozook boozook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please set version of playdate package to 0.2.0 here.

Thanks! ❤️‍🔥

api/lua/Cargo.toml Outdated Show resolved Hide resolved
@boozook boozook enabled auto-merge (squash) May 7, 2024 01:18
@boozook boozook merged commit 0779ab8 into boozook:main May 7, 2024
36 checks passed
@paulyoung paulyoung deleted the paulyoung/lua branch May 7, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api About Playdate API, bindings and all over that. docs Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add lua api
2 participants