423 remove service discovery #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksondelametter
force-pushed
the
423-remove-service-discovery
branch
from
15886a3
to
de72001
Compare
DRAFT_RELEASE_NOTES.md
Outdated
| @@ -101,4 +101,5 @@ If you added any custom configurations to the `sparkoperator` service account pe | |||
|
|
|||
| # What's Changed | |||
| - `pyproject.toml` files updated to allow for Python version `>=3.8`. | |||
| - All SageMaker modules and corresponding references were removed in commit bdcbb409. | |||
| - All SageMaker modules and corresponding references were removed in commit 8ce3f39. | |||
There was a problem hiding this comment.
Suggested change
| - All SageMaker modules and corresponding references were removed in commit 8ce3f39. | |
| - All SageMaker modules and corresponding references were removed in commit 8ce393f. |
DRAFT_RELEASE_NOTES.md
Outdated
| @@ -101,4 +101,5 @@ If you added any custom configurations to the `sparkoperator` service account pe | |||
|
|
|||
| # What's Changed | |||
| - `pyproject.toml` files updated to allow for Python version `>=3.8`. | |||
| - All SageMaker modules and corresponding references were removed in commit bdcbb409. | |||
| - All SageMaker modules and corresponding references were removed in commit 8ce3f39. | |||
| - The Service Discovery module and corresponding references were removed in commit 4a1d7abf. | |||
There was a problem hiding this comment.
You currently have 2 commits, so this is probably gonna change if you squash them
There was a problem hiding this comment.
Unfortunately I need to have two commits to do this. When you squash them, git changes the commit hash.
There was a problem hiding this comment.
Oh that makes sense, can't predict the squash commit hash
jacksondelametter
force-pushed
the
423-remove-service-discovery
branch
from
de72001
to
890e16f
Compare
carter-cundiff
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to remove the Service Discovery module. This also adds to the Draft Release Notes that the module has been removed as well as fix a commit hash reference to the removal of Sagemaker.