Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not alias rich text area if it is not defined #709

Merged
merged 6 commits into from
Oct 28, 2023
Merged

do not alias rich text area if it is not defined #709

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c2d4a1d
do not alias rich rext area if it is not defined
BenMorganMY Oct 5, 2023
45c0af3
rescue name error instead of checking if the method is defined
BenMorganMY Oct 25, 2023
061420c
ignore linting issues
BenMorganMY Oct 25, 2023
f1f02ca
add note on bootstrap_alias
BenMorganMY Oct 25, 2023
dbc7e18
use inline rubocop disable comment
BenMorganMY Oct 26, 2023
e77c68c
Update lib/bootstrap_form/inputs/base.rb
lcreid Oct 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ Layout/LineLength:
Layout/SpaceAroundEqualsInParameterDefault:
EnforcedStyle: no_space

Lint/SuppressedException:
Enabled: false

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See below.

Suggested change
Lint/SuppressedException:
Enabled: false

Metrics/AbcSize:
Max: 18
Exclude:
Expand All @@ -45,6 +48,7 @@ Metrics/AbcSize:

Metrics/BlockLength:
Exclude:
- "lib/bootstrap_form/inputs/base.rb"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can leave this one in here, since it applies to the whole file anyway. But I should look at the rule and where it came from. I'm a fan of RuboCop, but not of these rules that put arbitrary limits on the size of things.

- "demo/config/**/*"
- "demo/test/**/*"
- "test/**/*"
Expand Down
7 changes: 7 additions & 0 deletions lib/bootstrap_form/inputs/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,16 @@ def bootstrap_select_group(field_name)
bootstrap_alias field_name
end

# Creates the methods *_without_bootstrap and *_with_bootstrap.
#
# If your application did not include the rails gem for one of the dsl
# methods, then a name error is raised and suppressed. This can happen
# if your application does not include the actiontext dependency due to
# `rich_text_area` not being defined.
def bootstrap_alias(field_name)
alias_method "#{field_name}_without_bootstrap".to_sym, field_name
alias_method field_name, "#{field_name}_with_bootstrap".to_sym
rescue NameError
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to do the RuboCop exception specifically on the line.

Suggested change
rescue NameError
rescue NameError # rubocop:disable Lint/SupressedException

end
end

Expand Down