Rails 7.1 #708
Rails 7.1 #708
Conversation
lcreid
force-pushed
the
rails-7-1
branch
3 times, most recently
from
deb81b0
to
e362fc6
Compare
Fix bad git usage 7.1.0 released Docker get newer node and docs
| @@ -85,13 +85,20 @@ Docker is _not_ required to work on this gem. | |||
|
|
|||
| The `docker-compose` approach should link to enough of your networking configuration that you can release the gem. | |||
| However, you have to do some of the configuration yourself, because it's dependent on your host operating system. | |||
|
|
|||
There was a problem hiding this comment.
I feel the Docker documentation has grown so large it should be extracted into its own document (DOCKER.md) and then be referred from the CONTRIBUTING.md document.
There was a problem hiding this comment.
Good idea. I'll do that in a separate PR.
demo/Gemfile
Outdated
| @@ -2,7 +2,7 @@ source "https://rubygems.org" | |||
|
|
|||
| gem "bootstrap_form", path: ".." | |||
|
|
|||
| gem "rails", "~> 7.0.0" | |||
| gem "rails", "~> 7.1.0" | |||
There was a problem hiding this comment.
Might be a good idea to go directly to 7.1.1 since it contains bugfixes.
demo/Gemfile.lock
Outdated
| selenium-webdriver | ||
| sprockets-rails | ||
| sqlite3 (~> 1.4) | ||
| tzinfo-data | ||
| web-console | ||
|
|
||
| BUNDLED WITH | ||
| 2.4.13 | ||
| 2.4.1 |
There was a problem hiding this comment.
I think it is a good idea to keep up with newer versions of bundler using bundle update --bundler. At least not downgrade bundler without a reason.
There was a problem hiding this comment.
Agreed. I was using an older Docker container. Sometimes it seems like a stable development platform can cause more problems than it solves.
demo/config/application.rb
Outdated
|
|
||
| # Require the gems listed in Gemfile, including any gems | ||
| # you've limited to :test, :development, or :production. | ||
| Bundler.require(*Rails.groups) | ||
| require "bootstrap_form" | ||
| require "bootstrap_form" # FIXME: Why do we require this here? |
There was a problem hiding this comment.
Have you tried without this line?
There was a problem hiding this comment.
Argh. I was sure I had removed the FIXME. Anyway, yes, I have another branch where I'm doing some small fix-ups, and it seems to run fine without this require. Maybe I'll merge that branch before I release.
Add Rails 7.1 to the matrix. Also add
ruby-headto the matrix.This was remarkably painful to finish. A small change in the behaviour of
rails db:preparebroke our tests, and that sent me off on a adventure through a couple of other PRs that were supposed to help me get the tests running for Rails 7.1, but ended up being a lot of work in themselves. Sigh.Most of the changes in this PR are files generated by the Rails upgrade of the demo app.
One of the things I tried was simply ignoring the new table, hoping that that would fix (or at least delay) the need to deal with the change to
db:prepare, but the model, and therefore the table, is referenced somewhere deep in the Rails initialization code.Also of note: I don't think anything about Rails 7.1 actually broke the gem. The problems I had or caused myself were because of the way we test the gem.
I'll do a release to 5.4.0 after merging this PR.