-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve checkbox layout #686
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I share your concern about these being breaking changes, but since we're really fixing stuff that was broken before (mis-aligned fields and labels, for example), I think making the change is reasonable.
I'd like to see what you think about my comments and questions before I approve, but overall I really like what I'm seeing.
723cbb9
to
0808baa
Compare
The edge test failures are #691 |
7437dc9
to
0bb953e
Compare
Indent checkbox into second column for horizontal layout. Override with layout: :default Align label with the top of the first check box in a collection in horizontal layout Vertically align check boxes and labels in inline layout. Allow overriding the label class, not just add more classes. Avoid duplicate form label classes.
0bb953e
to
36cf712
Compare
@lcreid Good to merge? |
I'll go ahead and merge this, then. |
I've noticed this makes it difficult to add Previously I could do:
Now I need to remove all This now changed and Now it's enough to set just:
However there is no way how to add additional text like
|
Since there are breaking changes, overriding the label class and indenting the check box into the second column for horizontal layout, I would like to bump the version number to 5.3 also to indicate that we now support Bootstrap 5.3.