default form-inline class applied to parent content div on date select helpers

[lancecarlson]

can also override this behavior with skip_inline: true

[lancecarlson]

Fixes: #460

[lcreid]

I suspect that you will need to be more specific here about when to add form-inline. I believe you only want to add it when the form_layout is :horizontal.

[lcreid]

Is the :skip_inline option a new option you're proposing? If so, could you please update the CHANGELOG to note the new functionality, and probably add a description of the option in the README.

[lcreid]

Thanks for this PR. We really appreciate your contribution. Sorry for my delay in responding. We're all volunteers on this project, so we can't always respond right away.

Since your PR identified a gap in our testing, it would help to have a test case in the PR. You can see in test/bootstrap_selects_test.rb, around line 256, there's the basic date select test, which you could copy and use as a starting point. One trick you can use is that we have an instance variable in all tests set up to build horizontal forms. It's called @horizontal_builder. You can use it in place of @builder and update the expected HTML to create a test case that fails, then write the code that makes the test case pass, at the same time that all the existing test cases pass.

To run the tests, type: bundle exec rake. I just noticed that somehow the instructions on how to run tests are not that obvious in our CONTRIBUTING document. Sorry about that.

[lancecarlson]

@lcreid I have no problem writing tests, but I'm having a hard time getting them to run. It keeps saying this:

ActiveRecord::StatementInvalid: Could not find table 'users'

Ah, I just reversed the order of the contributing instructions by running the schema load command first and I go past this error. Maybe we want to reverse the order in the contributing doc?

[lcreid]

Yes. I just figured that out myself. I'll fix the documentation.

[lcreid]

Documentation fix in PR #462.

[lancecarlson]

@lcreid I updated the changelog in this latest commit, but I'm not entirely sure where the skip_inline on the field helper should be documented. I only put it there so people could override if that wasn't the behavior they wanted.

[lcreid]

Sorry for not following up on this sooner! This is looking good, but it occurs to me that we should do the same for time_select and datetime_select. Would you mind adding those to this PR similarly to the way you did date_select? Sorry I didn't mention this sooner.

[lcreid]

@lancecarlson Could you please resolve the conflicts in this PR.

git fetch upstream
git checkout master
git rebase upstream/master

Fix the conflicts and commit the changes. Then just:

git push

Github will update the pull request.

[lcreid]

@lancecarlson Please let me know if you're going to add this functionality for time_select and datetime_select. I can do it if you don't have time. Just let me know, please. Thanks in advance!

[lcreid]

@lancecarlson thanks for the PR! My apologies for not noticing sooner that you had extended it to cover all the date and time selects. I resolved the conflicts.

@mattbrictson can you please take a quick look at this to make sure the PR doesn't add functionality that it shouldn't? The Bootstrap 4 version was stacking the fields for date and time, rather than putting them in the more intuitive side-by-side #460.