Change form_group_builder method to public

[antpaw]

I would like to have this method as a public method. With it i can pass in a block for just the input, and not care about error, help or label text. I can add docs, tests and changelog if this is considered a good idea.

Example:

<%= f.form_group_builder :signup_ends, wrapper_class: 'js-datepicker' do %>
  <div class="row">
    <div class="col-xs-6 col-lg-4">
      <input type="text" class="form-control js-date" required="required">
    </div>
    <div class="col-xs-4 col-lg-3">
      <input type="text" class="form-control js-time" required="required">
    </div>
    <%= f.hidden_field(:signup_ends, class: 'js-timestamp')) %>
  </div>
<% end %>

[mattbrictson]

It has been a while since I've reviewed the code, so could you refresh my memory: what is the difference between form_group and form_group_builder? I assume that form_group is not what you need for your use case, but could you explain that in more detail?

I'm not opposed to making form_group_builder public if I first understand its intended usage. Maybe you could share a draft of the documentation you plan on adding for it? Thanks!

[antpaw]

Hi, no problem, here is the difference, its much more convienient for me to use the form_group_builder because i don't need to care about about error, help or label elements, they will just be appended if needed

form_group_builder:

<div class="form-group">
   <label class="control-label" for="player_is_captain">Is Captain</label>
   <div class="form-check"><label class="form-check-label" for="player_is_captain">
      <input name="player[is_captain]" type="hidden" value="0">
      <input class="form-check-input" type="checkbox" value="1" checked="checked" name="player[is_captain]" id="player_is_captain"> 
      Is Captain
   </label>
</div>
</div>

form_group:

<div class="form-group">
  <div class="form-check">
     <label class="form-check-label" for="player_is_captain">
        <input name="player[is_captain]" type="hidden" value="0">
        <input class="form-check-input" type="checkbox" value="1" checked="checked" name="player[is_captain]" id="player_is_captain"> 
        Is Captain</label>
    </div>
</div>

[mattbrictson]

Closed in favor of #289.