Get luminol working with ml.co #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the ml.co app needs to make a call to the luminol server, this is exposing the url so that it can make that call.
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
=========================================
- Coverage 81.11% 81.1% -0.02%
=========================================
Files 10 10
Lines 376 381 +5
Branches 56 60 +4
=========================================
+ Hits 305 309 +4
- Misses 63 64 +1
Partials 8 8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few fixes to get luminol working with the metalab.co project.
There are a few bug fixes, and one addition which exposes the url to the API so that the metalab.co repo can query luminol.