Support React 16 #53
Merged
Support React 16 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`findDOMNode` is slated for deprecation soon, and support in React 16 appears to be partially dropped already. For us to transition completely away from it, we would need to pass a ref prop down to the provided `content` component, including it as part of the `FlowTip` api. This is less ideal than automatically resolving the correct ref as `findDOMNode` currently does and would make the lib more complicated to use. Until `findDOMNode` support is dropped completely, or we decide on a clean mechanism for passing the ref around, we rely on a custom `findDOMNOde` function that will safely attempt to detect the rendered node using react fiber internals when necessary. This universally supports React 16 and earlier versions. (See: https://stackoverflow.com/questions/48062095/update-to-react-16-finddomnode-stops-working#answer-48273014)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findDOMNodeis slated for deprecation soon, and support in React 16 appears to be partially dropped already.For us to transition completely away from it, we would need to pass a ref prop down to the provided
contentcomponent, including it as part of theFlowTipapi. This is less ideal than automatically resolving the correct ref asfindDOMNodecurrently does and would make the lib more complicated to use. (See: #55)Until
findDOMNodesupport is dropped completely, or we decide on a clean mechanism for passing the ref around, we rely on a customfindDOMNodefunction that will safely attempt to detect the rendered node using react fiber internals when necessary. This universally supports React 16 and earlier versions.See: