Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally set C++11 requirements #396

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Flamefire
Copy link
Contributor

Reduced variant of #395 where the requirements are only set when lexical_cast is directly used, i.e. in the pthread case.

However this fails/failed on Appveyor due to date_time using lexical_cast and also src/win32/thread_primitives.cpp including atomic which uses static_assert

So to me #395 looks more correct but I wanted to provide both solutions for you to choose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant