Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static_wstring should be conditionally enabled #51

Closed
jwt27 opened this issue Sep 4, 2023 · 4 comments · Fixed by #52
Closed

static_wstring should be conditionally enabled #51

jwt27 opened this issue Sep 4, 2023 · 4 comments · Fixed by #52
Assignees
Labels
Bug Something isn't working

Comments

@jwt27
Copy link

jwt27 commented Sep 4, 2023

Hi!

static_wstring fails to compile on platforms that don't have libc support
for wide-character strings. I got it to work by defining a no-op
std::swprintf(...), but obviously that isn't really a solution.

However, boost::config has feature detection macros for this: BOOST_NO_CWCHAR
and BOOST_NO_SWPRINTF. So ideally, static_wstring should be conditionally
enabled based on those.

@sdkrystian
Copy link
Member

Reasonable, I'll take care of this soon

@sdkrystian sdkrystian added the Bug Something isn't working label Sep 7, 2023
@sdkrystian sdkrystian self-assigned this Sep 7, 2023
@alandefreitas
Copy link
Member

Please note this was probably because of the standalone library. We would need two paths here.

@sdkrystian
Copy link
Member

@alandefreitas I'm not sure if it's worth trying to replicate BOOST_NO_CWCHAR in standalone.. Might be better to just check for cwchar in standalone?

@alandefreitas
Copy link
Member

Probably not. Whatever is easier in standalone. We can have a separate path for boost.

sdkrystian added a commit to sdkrystian/static_string that referenced this issue Oct 24, 2023
sdkrystian added a commit to sdkrystian/static_string that referenced this issue Oct 24, 2023
sdkrystian added a commit to sdkrystian/static_string that referenced this issue Oct 24, 2023
sdkrystian added a commit that referenced this issue Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants