Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for buffering behavior of iostreams #187

Merged
merged 3 commits into from
Oct 19, 2024
Merged

Add test for buffering behavior of iostreams #187

merged 3 commits into from
Oct 19, 2024

Conversation

Flamefire
Copy link
Collaborator

Closes #186

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.47%. Comparing base (bac0f20) to head (5fffda9).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #187      +/-   ##
===========================================
+ Coverage    99.45%   99.47%   +0.02%     
===========================================
  Files           34       34              
  Lines         3319     3460     +141     
===========================================
+ Hits          3301     3442     +141     
  Misses          18       18              
Files with missing lines Coverage Δ
src/iostream.cpp 100.00% <100.00%> (ø)
test/test_iostream.cpp 100.00% <100.00%> (ø)

... and 20 files with indirect coverage changes

@Flamefire Flamefire force-pushed the buffering branch 3 times, most recently from fb17c65 to 583bf53 Compare October 18, 2024 08:47
buffering may be independent of tied streams, so make it an extra param
@Flamefire Flamefire merged commit 015be20 into develop Oct 19, 2024
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boost::nowide::cerr is buffered
1 participant