fix: add condition to handle_imperfect_touch #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barendgehrels
commented
Nov 20, 2024
include/boost/geometry/algorithms/detail/overlay/get_turn_info_helpers.hpp
Show resolved
Hide resolved
barendgehrels
commented
Nov 20, 2024
barendgehrels
force-pushed
the
fix/issue-1345
branch
from
6688aa8 to
cd4deda
Compare
barendgehrels
commented
Nov 20, 2024
barendgehrels
commented
Nov 24, 2024
barendgehrels
force-pushed
the
fix/issue-1345
branch
from
b445c36 to
68d4129
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1345
Edit also fixes #1288 which is added because it was similar.
About #1345
Difference was wrong for both cases, caused by nearly opposite segments. The condition causing this had to be fine-tuned with an extra check.
Fixed behaviour:
a (
p=big polygon containing all,q=small rectangle at top which subtly overlapsp)Difference a-b (in image, this should be a rectangle, correct)
Difference b-a -> 0 (correct)
b (
p= u-shape,q= the lower bar of it, subtly overlappingp)Difference
a-b(in image, this should be the two vertical bars of the u, correct)Difference
b-a-> 0 (correct)About #1288
It handled a situation as a "touch" but both the middle points were not collinear. In those cases it should not be handled as a touch and use the "original" code path.
The "mystery" why it happened only for polygon and not for multi-polygon, and this affects also the validity check, is not yet solved - but the case itself is solved.
The multi/poly combination is not yet unit tested, I have another test for that in preparation but it's better to not have large chuncks in the beta-time for the release.