traverse first through non clustered turns, remove cluster exits, make priority consistent #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, make priority consistent fixes boostorg#1293 boostorg#1294 and boostorg#1295
barendgehrels
commented
Jul 30, 2024
| return OverlayType == overlay_buffer || is_self_turn<OverlayType>(turn) | ||
| ? select_source_generic<&segment_identifier::multi_index>( | ||
| turn, candidate_seg_id, previous_seg_id) | ||
| : select_source_generic<&segment_identifier::source_index>( |
There was a problem hiding this comment.
This is not part of the fix but makes code more concise and readable
barendgehrels
commented
Jul 30, 2024
| { | ||
| // Check counts: in some cases interior rings might be generated with | ||
| // polygons on both sides. For dissolve it can be anything. | ||
|
|
||
| // If this forms a spike, going to/from the cluster point in the same | ||
| // (opposite) direction, it can still be used. | ||
| return cinfo.spike_count > 0 ? 1 : 0; | ||
| return 1; |
There was a problem hiding this comment.
Returning 0 was a bug, it should only have returned 1.
So that is fixed and is necessary to avoid regressions with this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1293 #1294 and #1295
This PR fixes several issues. There are no regressions.
More detailed:
issue_630_b(a relatively simple case)cluster_exits(a welcome removal, see below)Removing cluster_exits is welcome because it was designed as a simple approach, not needing many conditions. But in the end there are conditions there as well, and (apparently) bugs. So it is welcome to remove it again and keep the code having one approach, used for both union and intersection in the same way.