Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error when the compiler is not supported #215

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JackBoosY
Copy link

The current behavior will mislead the user into thinking that configuration was successful, when in fact it failed due to unsupported compiler version.

@klemens-morgenstern
Copy link
Collaborator

That's not a solution, that would break any cmake build on compilers that don't support C++20.
The configuration is fine as is, you can build boost, just without cobalt. This requires a fix on vcpkg.

@JackBoosY
Copy link
Author

That's not a solution, that would break any cmake build on compilers that don't support C++20. The configuration is fine as is, you can build boost, just without cobalt. This requires a fix on vcpkg.

If I understand correctly, the configuration step will break when the compiler doesn't support cxx 20, isn't it?

@klemens-morgenstern
Copy link
Collaborator

Correct.

@JackBoosY
Copy link
Author

JackBoosY commented Dec 12, 2024

Correct.

So I don't know why this changes is incorrect.
If the compiler doesn't meet the requirements, it should be FAILED at configure step, not just return and pass.

This affects not only vcpkg, but all steps using the command line, as they will collect the results of whether the configuration passed or not.

@klemens-morgenstern
Copy link
Collaborator

Because this is built as part of boost. Your change would make configuring boost fail if the compiler isn't supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants