Remove usage of deprecated and removed Boost.Filesystem APIs

[Lastique]

No description provided.

[Lastique]

The b2 crash in the CI is reported here: bfgroup/b2#367.

[jzmaddock]

Thanks for this!

[pdimov]

bcp doesn't seem to build in 1.85 because this PR hasn't been merged.

[Lastique]

I suspect, it wasn't merged because of the b2 issue. I think, this can be merged despite that issue, if only to fix the build.

Note: the first commit in this PR fixes the compilation, the second one updates the dependencies that should fix the CI once b2 is fixed.

[pdimov]

The b2 issue is unrelated. Not merging this won't fix it.

[jzmaddock]

My bad. I didn't merge because we can't tell if the patch is really working until the tests run... (I appreciate it compiles, but that's not quite the same thing as working).

[pdimov]

Rene says it doesn't crash for him, so let's close and reopen and see if that helps. :-)

[pdimov]

Nope, still crashes. @grafikrobot

[Lastique]

Note that the CI uses the b2 version that was released in Boost.

[grafikrobot]

The B2 problem was not technically a B2 problem. It was actually a Predef problem. But only the Boost Predef, not the independent Hash Predef. But also none of the following will make the BCP tests work. As BCP is not copying the correct predef/tools/check/predef.jam file. The following changes will prevent the stack overflow crash:

• bfgroup/b2@e249722 (B2 change that addresses the general stack overflow problem)
• boostorg/predef@9aca7f5
• Don't use obsolete predef/checks/predef.jam B2 module. vmd#14
• Don't use obsolete predef/checks/predef.jam B2 module. test#414
• Don't use obsolete predef/checks/predef.jam B2 module. test#413
• Don't use obsolete predef/checks/predef.jam B2 module. math#1122
• Don't use obsolete predef/checks/predef.jam B2 module. locale#227

And saying again.. None of those changes will make this PR build. As the tip of the problem is that BCP doesn't copy predef/tools/check/predef.jam.

[Lastique]

Thanks, Rene. I've added the dependency on libs/predef/tools/check in addition to libs/predef/check.

[Lastique]

@jzmaddock Could you merge this, please?

[kwaegel]

Is this fixed, or is it still waiting for some of the predef PRs to get merged? I'm still seeing the same error messages trying to run BCP from the Boost 1.86.0 tarball release.

[edit] There is another ticket open about this, saying the fix has been merged to the develop branch but not the master branch that the boost repo tracks: #18

[Lastique]

This wasn't merged to master before 1.86.0, so it didn't make it to the release. It is merged now, so it should make it into the next one.