Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: getters not working when return type is a promise of an array of… #1557

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: getters not working when return type is a promise of an array of… #1557

wants to merge 1 commit into from

Conversation

hendrik-depauw-lemon
Copy link

… objects

Description

Changes

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

@what-the-diff What The Diff
Copy link

what-the-diff bot commented Nov 4, 2024

PR Summary

  • Improved Handling of Promises in Source Data
    • The code now checks if a certain value (source[key]) is a Promise. If it is, the code will wait for it to resolve before it proceeds. This ensures that all data is properly processed, even if it's delivered in the form of a Promise, enhancing the reliability of the code.

javiertoledo
javiertoledo approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@javiertoledo javiertoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hendrik-depauw-lemon
Copy link
Author

Can we get this merged? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiertoledo javiertoledo javiertoledo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hendrik-depauw-lemon @javiertoledo