Fe/bugfix/#524 sidebar 관련버그 수정 #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 계속 테스트하기 너무 귀찮아서... - import.meta.env.DEV일경우 비밀번호 1로 고정
- 헤더는 변경될일 없으므로 key로 index를 넣어줌
kimyu0218
approved these changes
Feb 16, 2024
frontend/src/utils/random.ts
Outdated
| @@ -4,5 +4,6 @@ export function randomString(length: number = 8) { | |||
| for (let i = 0; i < length; i++) { | |||
| result += chars.charAt(Math.floor(Math.random() * chars.length)); | |||
| } | |||
| if (import.meta.env.DEV) return 1; | |||
Deploying with
|
| Latest commit: |
44cb145
|
| Status: | 🚫 Build failed. |
HeoJiye
approved these changes
Feb 16, 2024
| className="w-h-full transition-transform ease-in-out duration-500" | ||
| className={`w-h-full transition-transform ease-in-out duration-500`} |
There was a problem hiding this comment.
❓ 이거 왜 이렇게 바꾼거야? 안에 변수 넣었다가 뺀건가?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔮 resolved #524
변경 사항
고민과 해결 과정
처음에 생각했던 문제 -> 상대방이 접속하면 상태가 바뀌고 화면이 리렌더링됨
근데 리렌더링 되는데
왜?오른쪽으로 스크롤이 되지 에 대한 문제때문에 시간이 많이 소요됨그래서 상태 변경을 없애버렸는데도 불구하고 동일한 문제가 반복돼서 html문제라 생각하게됨
원인은 자식요소에
display:absoluteleft: 100%을 주고서 부모가 다시 리렌더링 됐을 때화면이 오른쪽 끝으로 스크롤됨. 모든 요소에 overflow:hidden을 줘도 동일한 증상이 반복됨
웃긴건 아예 오른쪽 끝으로 이동되는게 아니라 왼쪽을 조금 남기고 이동함
원인은 찾았는데 이게 왜 원인인지는 아직 이유를 찾지 못해서 1.0 배포 후 이유를 찾을 예정
(선택) 테스트 결과
문제가 됐던 부분
absolute.mov
해결 후
fixed.mov