FE/refactor/#517 파일위치 용도에맞게 이동 #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 이동하면서 import, export 구조 변경 - 테스트 실패한 케이스 다시 되도록 수정
Closed
kimyu0218
approved these changes
Feb 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경 사항
고민과 해결 과정
기존에는 폴더의 위치가 용도에 맞게 있지 않았었고, 그래서 파일을 찾기 힘들었음
그래서 이를 수정하고, import, export 구조도 수정함
이전엔 어떤 A 컴포넌트를 import하면 import A from '@components/A'; 이런식으로 A에서 A를 불러왔는데 부자연스럽다고 생각했음.
그래서 A라는 공용 컴포넌트를 import하면 import {A} from '@components/common' 이런식으로 더 알아보기 쉽게 변경함
변경하면서 깨진 테스트코드도 수정해둠