FE/feature/#502 useOverlay훅 테스트코드 작성 #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경 사항
고민과 해결 과정
useOverlay는 오버레이를 추가하고, 닫는 훅임
그래서 이 두가지 동작이 제대로 되는지에 대해 테스트를 진행함.
방법은 두가지가 있었음 실제로 테스트 컴포넌트를 작성하고, 안에서 제대로 동작이 되는지 보는것과
react testing library가 제공하는 renderHook 메서드를 사용하는것.
굳이 테스트코드를 위한 테스트컴포넌트를 작성할정도로 복잡한 로직도 아니고
다른 훅을 의존하지 않기에 renderHook 메서드를 사용함
이 때 waitFor을 사용했는데 waitFor는 변경된 결과를 기다릴 때 사용하라고 문서에 가이드가 있었음 링크
그래서 act로 유저의 액션을 동기적으로 일으킴 링크 그래서 리렌더링 되면 act 메서드 다음줄로 넘어가게 됨
(선택) 테스트 결과
closed #502