Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fe/feature/#495 로그인 팝업 컴포넌트 작성 #497

Merged
merged 9 commits into from
Jan 26, 2024

Conversation

HeoJiye
Copy link
Collaborator

@HeoJiye HeoJiye commented Jan 24, 2024

Fe/feature/#482 fe kakao oAuth 구현 #483 먼저

resolve #495

변경 사항

ex) 로그인 시, 구글 소셜 로그인 기능을 추가했습니다.

  • Button 컴포넌트 width, height 지정 가능한 옵션 추가함
  • ai와 타로보기 클릭 시 로그인 팝업이 뜸
    • 카카오로 시작하기 -> 카카오 로그인 후 ai 타로 채팅으로 이동
    • 로그인 없이 타로 볼래요 -> 로그인 없이 ai 타로 채팅으로 이동
  • TODO: client에서 로그인 여부가 구분이 되어야 함

고민과 해결 과정

(선택) 테스트 결과

ex) 베이스 브랜치에 포함되기 위한 코드는 모두 정상적으로 동작해야 합니다. 결과물에 대한 스크린샷, GIF, 혹은 라이브 데모가 가능하도록 샘플API를 첨부할 수도 있습니다.

녹화_2024_01_24_17_27_37_464

Copy link
Collaborator

@kimyu0218 kimyu0218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 카카오 로그인 버튼 안 쓰면 빼고 올려도 될 것 같아!

Comment on lines 10 to 12
const res = await fetch(KAKAO_LOGIN_URL + `?code=${code}`, {
credentials: 'include',
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 아까 PR 내용이 여기에도 반영된 것 같아!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맞아! 로그인 로직 연결까지 한번에 하려구..

frontend/src/components/Popup/LoginPopup.tsx Outdated Show resolved Hide resolved
Copy link

cloudflare-workers-and-pages bot commented Jan 24, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a4691f1
Status: ✅  Deploy successful!
Preview URL: https://744e3c7d.web09-magicconch.pages.dev
Branch Preview URL: https://fe-feature--495-luit.web09-magicconch.pages.dev

View logs

@HeoJiye HeoJiye self-assigned this Jan 24, 2024
@HeoJiye HeoJiye requested a review from Doosies January 25, 2024 04:33
@HeoJiye HeoJiye merged commit b33045f into dev Jan 26, 2024
1 check passed
@HeoJiye HeoJiye deleted the FE/feature/#495-로그인-팝업-컴포넌트-작성 branch January 26, 2024 11:22
@HeoJiye HeoJiye mentioned this pull request Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✅ FEATURE: 로그인 팝업 컴포넌트 작성
3 participants