DiaryEditViewController 구성 / Location 흐름 구축 #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudah7
approved these changes
Dec 8, 2022
| debugPrint("위치 서비스 on") | ||
| self.locationManager.startUpdatingLocation() | ||
| } else { | ||
| print("위치 서비스 off 상태") |
There was a problem hiding this comment.
그냥 보다가 궁금해진건데, 다른 부분들은 debugPrint() 쓰시다 여기는 print()군요..?!
radiantchoi
approved these changes
Dec 8, 2022
Comment on lines
+14
to
+15
| var locationSubject: PublishSubject<Location> { get set } | ||
| var addressSubject: PublishSubject<String> { get set } |
There was a problem hiding this comment.
subject에 대한 고민이 정말.. 사람 미치게 하죠ㅎㅎㅋㅋ 이 주제에 대해서 오늘내일 이야기를 나눠 보고, 이번 주 칼럼에 실어 봅시다.
| debugPrint("tags : ", tags) | ||
| // TODO: 이미지 업로드 해야 | ||
| debugPrint("bodyText : ", bodyTextView.text) | ||
| // TODO: MusicInfo엔 어떤 정보가 string으로? |
There was a problem hiding this comment.
이 부분이 아마 "오늘 할 일"의 카테고리를 달고 넘어가게 될 것 같은데, 머지하기 전에 이야기를 나눠봅시다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
12/7 #166 #168 #171
작업한 내용
imagePicker를 통해 갤러리의 이미지를 선택하고, 뷰에 반영될 수 있도록 했습니다.
태그 추가 시 적절한 UI 형태로 반환하도록 했습니다.
위치 버튼을 눌렀을 때 레포지토리를 통해 위치를 가져오는 일련의 흐름을 구축했습니다.