feat BE 유저 참여 API 구현 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claycat
reviewed
Nov 23, 2022
| } | ||
|
|
||
| async isParticipaite(recruitId: number, userId: number): Promise<boolean> { | ||
| return this.userRecruitRepository.isParticipate(recruitId, userId); |
There was a problem hiding this comment.
오타 : isParticipate
근데 네이밍자체는 isParticipating 이 좀 나을수도 있을꺼같아요
claycat
reviewed
Nov 23, 2022
| return await this.findOneBy({ id: recruitId }); | ||
| } | ||
|
|
||
| async getMaxPpl(recruitId: number) { |
There was a problem hiding this comment.
getMaxPeople 의 줄임말같은데 굳이 줄일 필요가 있을까요?
There was a problem hiding this comment.
db에 maxPpl로 저장되어있어서 통일성을 위해 Ppl로 했습니다
claycat
reviewed
Nov 23, 2022
| }); | ||
| } | ||
|
|
||
| async findOneById(recruitId: number): Promise<Recruit | undefined> { |
There was a problem hiding this comment.
find"One"ById 에서 "one" 이 어떤거인지 잘 모르겠어요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
사용자가 러닝 모집에 참여하기 위한 API를 구현한다.
사용자가 러닝 모집에 참여하도록 하기 위함
과정
결과 (스크린샷 등)
유저 참여에 성공한 경우
모집 글이 없거나 삭제된 경우
모집 글 게시자와 참여하려는 유저가 동일한 경우
이미 해당 모집에 참여한 경우
모집이 완료된 경우
관련 issue 번호 (링크)
#60
테스트 방법
POST localhost:4000/recruit/joinCommit